Skip to content

SPLAT-2167: Added dedicated hosts support for AWS #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2025
Merged

SPLAT-2167: Added dedicated hosts support for AWS #1419

merged 3 commits into from
Nov 13, 2025
+577 −217,485

Conversation

@vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Sep 18, 2025 •
edited
Loading

SPLAT-2167

Changes

  • Added logic to webhook to validate fields are correct

Dependencies

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 18, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2167 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2167

Changes

  • Added logic to webhook to validate fields are correct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2167 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2167

Changes

  • Added logic to webhook to validate fields are correct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2167 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2167

Changes

  • Added logic to webhook to validate fields are correct

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This was referenced Oct 16, 2025
Merged
Merged
@vr4manta
Copy link
Contributor Author

vr4manta commented Oct 23, 2025

/test all

1 similar comment
@vr4manta
Copy link
Contributor Author

vr4manta commented Oct 23, 2025

/test all

@vr4manta
Copy link
Contributor Author

vr4manta commented Oct 23, 2025

/test all

@vr4manta
Copy link
Contributor Author

vr4manta commented Oct 23, 2025

/test all

@vr4manta
Copy link
Contributor Author

vr4manta commented Oct 24, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6d3e6260-b0cb-11f0-937d-265094b680a5-0

everettraven
everettraven reviewed Oct 24, 2025
View reviewed changes
Copy link

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a review of the validation implementation as part of reviewing openshift/api#2484

@vr4manta vr4manta force-pushed the SPLAT-2167 branch 2 times, most recently from 302271d to 45d4104 Compare October 29, 2025 15:08
@vr4manta
Copy link
Contributor Author

vr4manta commented Oct 29, 2025

/test all

@vr4manta
Copy link
Contributor Author

vr4manta commented Oct 29, 2025

/test all

everettraven
everettraven reviewed Nov 3, 2025
View reviewed changes
@vr4manta vr4manta force-pushed the SPLAT-2167 branch 2 times, most recently from 02a435f to 2ebab11 Compare November 3, 2025 17:20
@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 3, 2025

/test all

@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 4, 2025

/retest

everettraven
everettraven reviewed Nov 5, 2025
View reviewed changes
Copy link

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validations on the webhook LGTM

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 11, 2025

/test all

@vr4manta vr4manta changed the title [WIP] SPLAT-2167: Added dedicated hosts support for AWS SPLAT-2167: Added dedicated hosts support for AWS Nov 11, 2025
@vr4manta vr4manta marked this pull request as ready for review November 11, 2025 20:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 9ebb6da link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 12, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-dedicated periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-dedicated

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c20db8a0-bfcf-11f0-8043-273bb96a4735-0

@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 12, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b2c05fa0-bfd0-11f0-96a7-df8a269f3d96-0

damdo
damdo reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/assign @everettraven
For LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@jcpowermac
Copy link
Contributor

jcpowermac commented Nov 13, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 13, 2025

/verified by @vr4manta
MAPI2CAPI openshift/cluster-capi-operator#374
I've also been testing this with installer changes that are held up by upgrade to 1.11 CAPI.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2025

@vr4manta: This PR has been marked as verified by @vr4manta.

In response to this:

/verified by @vr4manta
MAPI2CAPI openshift/cluster-capi-operator#374
I've also been testing this with installer changes that are held up by upgrade to 1.11 CAPI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f5cae1f into openshift:main Nov 13, 2025
16 of 17 checks passed
@vr4manta vr4manta mentioned this pull request Nov 13, 2025
Open
@jcpowermac jcpowermac mentioned this pull request Nov 14, 2025
Open
@neisw neisw mentioned this pull request Nov 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@racheljpg racheljpg Awaiting requested review from racheljpg

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

+2 more reviewers

@jcpowermac jcpowermac jcpowermac left review comments

@everettraven everettraven everettraven left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jcpowermac jcpowermac

@everettraven everettraven

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vr4manta @openshift-ci-robot @jcpowermac @damdo @everettraven @openshift-merge-robot